Skip to content

Updated with match #24707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 16, 2019
Merged

Updated with match #24707

merged 6 commits into from
Jan 16, 2019

Conversation

rajibmitra
Copy link
Contributor

@rajibmitra rajibmitra commented Jan 10, 2019 •
edited
Loading

@TomAugspurger
Copy link
Contributor

@rajibmitra found another in pandas/tests/scalar/timestamp/test_unary_ops.py::TestTimestampUnaryOps::test_round_dst_border_nonexistent, if you could update that too.

@TomAugspurger
Copy link
Contributor

pandas/tests/series/test_datetime_values.py::TestSeriesDatetimeValues::test_dt_round_tz_nonexistent as well

@TomAugspurger
Copy link
Contributor

and pandas/tests/test_config.py::TestConfig::test_deprecate_option

@jreback
Copy link
Contributor

jreback commented Jan 10, 2019

@rajibmitra make sure you merge master

@rajibmitra
Copy link
Contributor Author

@jreback merged my master. thanks.

@rajibmitra
Copy link
Contributor Author

@TomAugspurger will do those changes in couple of minutes , give me some time. Thanks.

@gfyoung gfyoung added Testing pandas testing functions or related to the test suite IO Data IO issues that don't fit into a more specific label labels Jan 11, 2019
@TomAugspurger
Copy link
Contributor

@rajibmitra I'm going to push a few more fixups here.

@rajibmitra
Copy link
Contributor Author

sorry , got busy with other stuff, sure @TomAugspurger

@TomAugspurger
Copy link
Contributor

No worries.

@TomAugspurger TomAugspurger added this to the 0.24.0 milestone Jan 16, 2019
@TomAugspurger TomAugspurger mentioned this pull request Jan 16, 2019
Merged
@TomAugspurger
Copy link
Contributor

Merging this on green, since it's failing other builds.

@jreback
Copy link
Contributor

jreback commented Jan 16, 2019

lgtm.

@codecov
Copy link

codecov bot commented Jan 16, 2019

Codecov Report

Merging #24707 into master will increase coverage by 49.46%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #24707       +/-   ##
===========================================
+ Coverage   42.92%   92.38%   +49.46%     
===========================================
  Files         166      166               
  Lines       52382    52382               
===========================================
+ Hits        22485    48395    +25910     
+ Misses      29897     3987    -25910
Flag Coverage Δ
#multiple 90.81% <ø> (?)
#single 42.92% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/computation/pytables.py 92.37% <0%> (+0.3%) ⬆️
pandas/io/pytables.py 92.31% <0%> (+0.92%) ⬆️
pandas/util/_test_decorators.py 90.54% <0%> (+4.05%) ⬆️
pandas/compat/__init__.py 57.91% <0%> (+8.1%) ⬆️
pandas/core/config_init.py 99.24% <0%> (+9.84%) ⬆️
pandas/core/reshape/util.py 100% <0%> (+11.53%) ⬆️
pandas/core/api.py 100% <0%> (+13.33%) ⬆️
pandas/compat/numpy/__init__.py 92.85% <0%> (+14.28%) ⬆️
pandas/core/computation/common.py 85.71% <0%> (+14.28%) ⬆️
pandas/core/indexes/api.py 99% <0%> (+14.85%) ⬆️
... and 123 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a15a37...a32e827. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jan 16, 2019 •
edited
Loading

Codecov Report

Merging #24707 into master will increase coverage by 49.46%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #24707       +/-   ##
===========================================
+ Coverage   42.92%   92.38%   +49.46%     
===========================================
  Files         166      166               
  Lines       52382    52382               
===========================================
+ Hits        22485    48395    +25910     
+ Misses      29897     3987    -25910
Flag Coverage Δ
#multiple 90.81% <ø> (?)
#single 42.92% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/computation/pytables.py 92.37% <0%> (+0.3%) ⬆️
pandas/io/pytables.py 92.31% <0%> (+0.92%) ⬆️
pandas/util/_test_decorators.py 90.54% <0%> (+4.05%) ⬆️
pandas/compat/__init__.py 57.91% <0%> (+8.1%) ⬆️
pandas/core/config_init.py 99.24% <0%> (+9.84%) ⬆️
pandas/core/reshape/util.py 100% <0%> (+11.53%) ⬆️
pandas/core/api.py 100% <0%> (+13.33%) ⬆️
pandas/compat/numpy/__init__.py 92.85% <0%> (+14.28%) ⬆️
pandas/core/computation/common.py 85.71% <0%> (+14.28%) ⬆️
pandas/core/indexes/api.py 99% <0%> (+14.85%) ⬆️
... and 123 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a15a37...a32e827. Read the comment docs.

@TomAugspurger TomAugspurger merged commit b99f8bc into pandas-dev:master Jan 16, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@rajibmitra @Pingviinituutti
TST: Updated with match (pandas-dev#24707)
e215981
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@rajibmitra @Pingviinituutti
TST: Updated with match (pandas-dev#24707)
dc92723
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
IO Data IO issues that don't fit into a more specific label Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.

Pytest Deprecation in test_pytables
4 participants
@rajibmitra @TomAugspurger @jreback @gfyoung